rework make realinstall and uninstall #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rusty-snake
commented
May 27, 2020
rusty-snake
commented
- remove -c, the manpage says it is ignored
-
$(DESTDIR)/$ (bindir)/. ->$(DESTDIR)$ (bindir) and so on - install contrib by file glob (*.py, *.sh)
- split long lines
- remove -c, the manpage says it is ignored - $(DESTDIR)/$(bindir)/. -> $(DESTDIR)$(bindir) and so on - install contrib by file glob (*.py, *.sh) - split long lines
Fred-Barclay
approved these changes
May 27, 2020
rusty-snake
commented
May 28, 2020
Comment on lines
+130
to
+136
| if [ ! -d $(DESTDIR)$(sysconfdir)/apparmor.d ]; then \ | ||
| install -m 0755 -d $(DESTDIR)$(sysconfdir)/apparmor.d \ | ||
| fi | ||
| install -m 0644 etc/apparmor/firejail-default $(DESTDIR)$(sysconfdir)/apparmor.d | ||
| if [ ! -d $(DESTDIR)$(sysconfdir)/apparmor.d/local ]; then \ | ||
| install -m 0755 -d $(DESTDIR)$(sysconfdir)/apparmor.d/local \ | ||
| fi |
There was a problem hiding this comment.
Any reasons why we need to check this?
|
Still present: #3435 (comment) |
rusty-snake
added a commit
that referenced
this pull request
Jun 4, 2020
revert long-line split and fix bash-completion
Closed
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jun 2, 2024
And remove the extraneous semicolon at the end of the command string. See also commit dae3933 ("rework make realinstall and uninstall (netblue30#3435)", 2020-06-04).
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jun 2, 2024
Changes: * Remove / after `$(DESTDIR)` * Remove useless -c * Use 0755 instead of 755 * Use -d after -m See also commit dae3933 ("rework make realinstall and uninstall (netblue30#3435)", 2020-06-04).
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jun 2, 2024
Changes: * Remove / after `$(DESTDIR)` * Remove useless -c * Use 0755 instead of 755 * Use -d after -m See also commit dae3933 ("rework make realinstall and uninstall (netblue30#3435)", 2020-06-04).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.